Contents

# encoding: utf-8
require 'rails_best_practices/reviews/review'

module RailsBestPractices
  module Reviews
    # Review a view file to make sure using simplified syntax for render.
    #
    # See the best practice details here http://rails-bestpractices.com/posts/61-simplify-render-in-views.
    #
    # Implementation:
    #
    # Review process:
    #   check all render method commands in view files,
    #   if there is a key 'partial' in the argument, then they should be replaced by simplified syntax.
    class SimplifyRenderInViewsReview < Review
      def url
        "http://rails-bestpractices.com/posts/61-simplify-render-in-views"
      end

      def interesting_nodes
        [:command]
      end

      def interesting_files
        VIEW_FILES
      end

      # check command node in view file,
      # if its message is render and the arguments contain a key partial,
      # then it should be replaced by simplified syntax.
      def start_command(node)
        if "render" == node.message.to_s
          hash_node =  node.arguments.all[0]
          if hash_node && hash_node.hash_keys && hash_node.hash_keys.include?("partial")
            add_error 'simplify render in views'
          end
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
rails_best_practices-1.2.0	lib/rails_best_practices/reviews/simplify_render_in_views_review.rb
rails_best_practices-1.1.0	lib/rails_best_practices/reviews/simplify_render_in_views_review.rb
rails_best_practices-1.0.1	lib/rails_best_practices/reviews/simplify_render_in_views_review.rb
rails_best_practices-1.0.0	lib/rails_best_practices/reviews/simplify_render_in_views_review.rb