Sha256: e92e878c3211c2c1514b859502a83af8226806d98ad58b6dfb455a6e14c51c33
Contents?: true
Size: 1.11 KB
Versions: 22
Compression:
Stored size: 1.11 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# This cop identifies places where `sort { |a, b| b <=> a }`
# can be replaced by a faster `sort.reverse`.
#
# @example
# # bad
# array.sort { |a, b| b <=> a }
#
# # good
# array.sort.reverse
#
class SortReverse < Base
include SortBlock
extend AutoCorrector
MSG = 'Use `sort.reverse` instead of `%<bad_method>s`.'
def on_block(node)
sort_with_block?(node) do |send, var_a, var_b, body|
replaceable_body?(body, var_b, var_a) do
range = sort_range(send, node)
add_offense(range, message: message(var_a, var_b)) do |corrector|
replacement = 'sort.reverse'
corrector.replace(range, replacement)
end
end
end
end
private
def message(var_a, var_b)
bad_method = "sort { |#{var_a}, #{var_b}| #{var_b} <=> #{var_a} }"
format(MSG, bad_method: bad_method)
end
end
end
end
end
Version data entries
22 entries across 22 versions & 3 rubygems