Sha256: e396b26c739bdb4f07522fdd8f91ac8841292e13eb3f472e97384e0d2db534ac

Contents?: true

Size: 1.66 KB

Versions: 6

Compression:

Stored size: 1.66 KB

Contents

# frozen_string_literal: true
#
# Copyright:: Copyright 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefCorrectness
        # Don't use node.save to save partial node data to the Chef Infra Server mid-run unless it's
        # absolutely necessary. Node.save can result in failed Chef Infra runs appearing in search and
        # increases load on the Chef Infra Server."
        #
        # @example
        #
        #   # bad
        #   node.save
        #
        class CookbookUsesNodeSave < Cop
          MSG = "Don't use node.save to save partial node data to the Chef Infra Server mid-run unless it's absolutely necessary. Node.save can result in failed Chef Infra runs appearing in search and increases load on the Chef Infra Server."

          def_node_matcher :node_save?, <<-PATTERN
            (send (send nil? :node) :save)
          PATTERN

          def on_send(node)
            node_save?(node) do
              add_offense(node, location: :expression, message: MSG, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 1 rubygems

Version Path
cookstyle-6.15.9 lib/rubocop/cop/chef/correctness/node_save.rb
cookstyle-6.15.5 lib/rubocop/cop/chef/correctness/node_save.rb
cookstyle-6.15.3 lib/rubocop/cop/chef/correctness/node_save.rb
cookstyle-6.14.7 lib/rubocop/cop/chef/correctness/node_save.rb
cookstyle-6.13.3 lib/rubocop/cop/chef/correctness/node_save.rb
cookstyle-6.12.6 lib/rubocop/cop/chef/correctness/node_save.rb