Sha256: e2e872b7180ebb4fa01a3d920530b6c8b71919f18e1aaa64d316fcdd7ae24c0f

Contents?: true

Size: 1.9 KB

Versions: 12

Compression:

Stored size: 1.9 KB

Contents

#
# Copyright:: Copyright 2020, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefSharing
        # Resource properties should include description fields to allow automated documention. Requires Chef Infra Client 13.9 or later.
        #
        # @example
        #
        #   # bad
        #   property :foo, String
        #
        #   # good
        #   property :foo, String, description: "Set the important thing to..."
        #
        class IncludePropertyDescriptions < Cop
          extend TargetChefVersion

          minimum_target_chef_version '13.9'

          MSG = 'Resource properties should include description fields to allow automated documention. Requires Chef Infra Client 13.9 or later.'.freeze

          # any method named property being called with a symbol argument and anything else
          def_node_matcher :property?, '(send nil? :property (sym _) ...)'

          # hash that contains description in any order (that's the <> bit)
          def_node_search :description_hash, '(hash <(pair (sym :description) ...) ...>)'

          def on_send(node)
            property?(node) do
              add_offense(node, location: :expression, message: MSG, severity: :refactor) unless description_hash(processed_source.ast).any?
            end
          end
        end
      end
    end
  end
end

Version data entries

12 entries across 12 versions & 1 rubygems

Version Path
cookstyle-6.11.4 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.10.2 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.9.0 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.8.0 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.7.3 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.6.9 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.5.3 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.4.4 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.3.4 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.2.9 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.2.5 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
cookstyle-6.1.6 lib/rubocop/cop/chef/sharing/include_property_descriptions.rb