Sha256: e2e1e2fb5f53ad59a151c92c2dfbb7cc61027f7b0503f02a0fa208dae44d1c74
Contents?: true
Size: 1.18 KB
Versions: 9
Compression:
Stored size: 1.18 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
# Prefer using verifying doubles over normal doubles.
#
# @see https://relishapp.com/rspec/rspec-mocks/docs/verifying-doubles
#
# @example
# # bad
# let(:foo) do
# double(method_name: 'returned value')
# end
#
# # bad
# let(:foo) do
# double("ClassName", method_name: 'returned value')
# end
#
# # good
# let(:foo) do
# instance_double("ClassName", method_name: 'returned value')
# end
class VerifiedDoubles < Base
MSG = 'Prefer using verifying doubles over normal doubles.'
def_node_matcher :unverified_double, <<-PATTERN
{(send nil? {:double :spy} $...)}
PATTERN
def on_send(node)
unverified_double(node) do |name, *_args|
return if name.nil? && cop_config['IgnoreNameless']
return if symbol?(name) && cop_config['IgnoreSymbolicNames']
add_offense(node)
end
end
private
def symbol?(name)
name&.sym_type?
end
end
end
end
end
Version data entries
9 entries across 9 versions & 1 rubygems