Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Ezcater
      # Use the `Rails.configuration.x` namespace for configuration backed by
      # environment variables, rather than inspecting `Rails.env` directly.
      #
      # Centralizing application configuration helps avoid scattering it
      # throughout the codebase, and avoids coarse environment grouping under
      # a single env var. See https://ezcater.atlassian.net/wiki/x/ZIChNg.
      #
      # @example
      #
      #   # good
      #   enforce_foo! if Rails.configuration.x.foo_enforced
      #
      #   # bad
      #   enforce_foo! if Rails.env.production?
      #
      #   # bad
      #   enforce_foo! if ENV["RAILS_ENV"] == "production"
      #
      class RailsEnv < Base
        MSG = <<~END_MESSAGE.split("\n").join(" ")
          Use `Rails.configuration.x.<foo>` for env-backed configuration instead of inspecting `Rails.env`, so that
          configuration is more centralized and gives finer control. https://ezcater.atlassian.net/wiki/x/ZIChNg
        END_MESSAGE

        def_node_matcher "rails_env", <<-PATTERN
          (send (send (const _ :Rails) :env) _ ...)
        PATTERN

        def on_send(node)
          rails_env(node) do
            add_offense(node.loc.expression, message: MSG)
          end
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
ezcater_rubocop-8.0.0	lib/rubocop/cop/ezcater/rails_env.rb
ezcater_rubocop-7.1.2	lib/rubocop/cop/ezcater/rails_env.rb
ezcater_rubocop-7.1.1	lib/rubocop/cop/ezcater/rails_env.rb
ezcater_rubocop-7.1.0	lib/rubocop/cop/ezcater/rails_env.rb