Contents

# encoding: utf-8

module Rubocop
  module Cop
    class IfThenElse < Cop
      ERROR_MESSAGE = {
        multiline_if_then:
        'Never use then for multi-line if/unless.',
        one_liner:
        'Favor the ternary operator (?:) over if/then/else/end constructs.',
        semicolon:
        'Never use if x; Use the ternary operator instead.'
      }

      def inspect(file, source, tokens, sexp)
        tokens.each_with_index do |t, ix|
          if t.type == :on_kw && ['if', 'unless'].include?(t.text)
            error = ERROR_MESSAGE[kind_of_if(tokens, ix + 1)]
            add_offence(:convention, t.pos.lineno, error) if error
          end
        end
      end

      def kind_of_if(tokens, ix)
        then_found = false
        tokens[ix..-1].each do |t|
          case t.type
          when :on_kw
            case t.text
            when 'then' then then_found = true
            when 'end'  then return :one_liner
            end
          when :on_ignored_nl, :on_nl
            break
          when :on_semicolon
            return :semicolon
          when :on_comment
            break if t.text =~ /\n/
          when :on_sp
            nil
          else
            then_found = false
          end
        end
        then_found ? :multiline_if_then : nil
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
rubocop-0.2.1	lib/rubocop/cop/if_then_else.rb
rubocop-0.2.0	lib/rubocop/cop/if_then_else.rb