Sha256: de4e5c3dce80771d630167d2c61ada16d7fb3b9cd583c77dc42961c48ec145e7
Contents?: true
Size: 1.79 KB
Versions: 8
Compression:
Stored size: 1.79 KB
Contents
# frozen_string_literal: true
#
# Copyright:: Copyright 2020, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
module Cop
module Chef
module ChefCorrectness
# Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal, which masks the full stack trace of the failure and makes debugging difficult.
#
# @example
#
# # bad
# Chef::Application.fatal!('Something horrible happened!')
#
# # good
# raise "Something horrible happened!"
#
class ChefApplicationFatal < Base
extend AutoCorrector
MSG = 'Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal'
def_node_matcher :application_fatal?, <<-PATTERN
(send
(const
(const nil? :Chef) :Application) :fatal!
$( ... ))
PATTERN
def on_send(node)
application_fatal?(node) do |val|
add_offense(node, message: MSG, severity: :refactor) do |corrector|
corrector.replace(node.loc.expression, "raise(#{val.source})")
end
end
end
end
end
end
end
end
Version data entries
8 entries across 8 versions & 1 rubygems