Sha256: dd398a19209d14724cd9b9c677a75451f9d2d7defda517956f4842002074a1d2
Contents?: true
Size: 1.93 KB
Versions: 13
Compression:
Stored size: 1.93 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# This cop identifies unnecessary use of a regex where
# `String#start_with?` would suffice.
#
# @example
# @bad
# 'abc' =~ /\Aab/
# 'abc'.match(/\Aab/)
#
# @good
# 'abc' =~ /ab/
# 'abc' =~ /\A\w*/
class StartWith < Cop
MSG = 'Use `String#start_with?` instead of a regex match anchored to ' \
'the beginning of the string.'.freeze
SINGLE_QUOTE = "'".freeze
def_node_matcher :redundant_regex?, <<-END
{(send $!nil {:match :=~} (regexp (str $#literal_at_start?) (regopt)))
(send (regexp (str $#literal_at_start?) (regopt)) {:match :=~} $_)}
END
def literal_at_start?(regex_str)
# is this regexp 'literal' in the sense of only matching literal
# chars, rather than using metachars like . and * and so on?
# also, is it anchored at the start of the string?
# (tricky: \s, \d, and so on are metacharacters, but other characters
# escaped with a slash are just literals. LITERAL_REGEX takes all
# that into account.)
regex_str =~ /\A\\A(?:#{LITERAL_REGEX})+\z/
end
def on_send(node)
add_offense(node, :expression, MSG) if redundant_regex?(node)
end
def autocorrect(node)
redundant_regex?(node) do |receiver, regex_str|
receiver, regex_str = regex_str, receiver if receiver.is_a?(String)
regex_str = regex_str[2..-1] # drop \A anchor
regex_str = interpret_string_escapes(regex_str)
lambda do |corrector|
new_source = receiver.source + '.start_with?(' +
to_string_literal(regex_str) + ')'
corrector.replace(node.source_range, new_source)
end
end
end
end
end
end
end
Version data entries
13 entries across 13 versions & 2 rubygems