require_relative 'smell_detector' require_relative 'smell_warning' module Reek module Smells # # An Uncommunicative Name is a name that doesn't communicate its intent # well enough. # # Poor names make it hard for the reader to build a mental picture # of what's going on in the code. They can also be mis-interpreted; # and they hurt the flow of reading, because the reader must slow # down to interpret the names. # # Currently +UncommunicativeParameterName+ checks for # * 1-character names # * names ending with a number # # See {file:docs/Uncommunicative-Parameter-Name.md} for details. class UncommunicativeParameterName < SmellDetector REJECT_KEY = 'reject'.freeze DEFAULT_REJECT_PATTERNS = [/^.$/, /[0-9]$/, /[A-Z]/, /^_/].freeze ACCEPT_KEY = 'accept'.freeze DEFAULT_ACCEPT_NAMES = [].freeze def self.smell_category 'UncommunicativeName' end def self.default_config super.merge( REJECT_KEY => DEFAULT_REJECT_PATTERNS, ACCEPT_KEY => DEFAULT_ACCEPT_NAMES ) end # # Checks the given +context+ for uncommunicative names. # # @return [Array] # def inspect(context) expression = context.exp expression.parameter_names.select do |name| sanitized_name = sanitize name uncommunicative_parameter_name?(name: sanitized_name, context: context) end.map do |name| smell_warning( context: context, lines: [expression.line], message: "has the parameter name '#{name}'", parameters: { name: name.to_s }) end end private def uncommunicative_parameter_name?(name: raise, context: raise) !acceptable_name?(name: name, context: context) && context.uses_param?(name) end def acceptable_name?(name: raise, context: raise) accept_names(context).any? { |accept_name| name == accept_name } || reject_patterns(context).none? { |pattern| name.match pattern } end def reject_patterns(context) value(REJECT_KEY, context, DEFAULT_REJECT_PATTERNS) end def accept_names(context) value(ACCEPT_KEY, context, DEFAULT_ACCEPT_NAMES) end # :reek:UtilityFunction def sanitize(name) name.to_s.gsub(/^[@\*\&]*/, '') end end end end