# frozen_string_literal: true module RuboCop module Cop module Lint # This cop checks constructors for disjunctive assignments that should # be plain assignments. # # So far, this cop is only concerned with disjunctive assignment of # instance variables. # # In ruby, an instance variable is nil until a value is assigned, so the # disjunction is unnecessary. A plain assignment has the same effect. # # @example # # bad # def initialize # @x ||= 1 # end # # # good # def initialize # @x = 1 # end class DisjunctiveAssignmentInConstructor < Cop MSG = 'Unnecessary disjunctive assignment. Use plain assignment.'.freeze def on_def(node) check(node) end private def check(node) return unless node.method_name == :initialize check_body(node) end # @param [DefNode] node a constructor definition def check_body(node) body = node.body case body.type when :begin check_body_lines(body.child_nodes) else check_body_lines([body]) end end # @param [Array] lines the logical lines of the constructor def check_body_lines(lines) lines.each do |line| case line.type when :or_asgn check_disjunctive_assignment(line) else # Once we encounter something other than a disjunctive # assignment, we cease our investigation, because we can't be # certain that any future disjunctive assignments are offensive. # You're off the case, detective! break end end end # Add an offense if the LHS of the given disjunctive assignment is # an instance variable. # # For now, we only care about assignments to instance variables. # # @param [Node] node a disjunctive assignment def check_disjunctive_assignment(node) lhs = node.child_nodes.first add_offense(node, location: :operator) if lhs.ivasgn_type? end end end end end