Sha256: dd052f2b7fcd53c5d7b181031497a3016f981a9c93b3f003abad4bb0630d3eaf
Contents?: true
Size: 1.67 KB
Versions: 11
Compression:
Stored size: 1.67 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for colons and commas in %i, e.g. `%i(:foo, :bar)`
#
# It is more likely that the additional characters are unintended (for
# example, mistranslating an array of literals to percent string notation)
# rather than meant to be part of the resulting symbols.
#
# @example
#
# # bad
#
# %i(:foo, :bar)
#
# @example
#
# # good
#
# %i(foo bar)
class PercentSymbolArray < Cop
include PercentLiteral
MSG = "Within `%i`/`%I`, ':' and ',' are unnecessary and may be " \
'unwanted in the resulting symbols.'.freeze
def on_array(node)
process(node, '%i', '%I')
end
def on_percent_literal(node)
return unless contains_colons_or_commas?(node)
add_offense(node)
end
def autocorrect(node)
lambda do |corrector|
node.children.each do |child|
range = child.loc.expression
corrector.remove_trailing(range, 1) if /,$/ =~ range.source
corrector.remove_leading(range, 1) if /^:/ =~ range.source
end
end
end
private
def contains_colons_or_commas?(node)
patterns = [/^:/, /,$/]
node.children.any? do |child|
literal = child.children.first
# To avoid likely false positives (e.g. a single ' or ")
next if literal.to_s.gsub(/[^[[:alnum:]]]/, '').empty?
patterns.any? { |pat| literal =~ pat }
end
end
end
end
end
end
Version data entries
11 entries across 11 versions & 2 rubygems