Sha256: da4e9186eb20e495c56d8f5caafc06dc257d2df670f33a121cb55193c61ff695

Contents?: true

Size: 1010 Bytes

Versions: 5

Compression:

Stored size: 1010 Bytes

Contents

# encoding: utf-8
require 'rails_best_practices/reviews/review'

module RailsBestPractices
  module Reviews
    # Review a helper file to make sure it is not an empty moduel.
    #
    # See the best practice details here http://rails-bestpractices.com/posts/72-remove-empty-helpers.
    #
    # Implementation:
    #
    # Review process:
    #   check all helper files, if the body of module is nil, then the helper file should be removed.
    class RemoveEmptyHelpersReview < Review
      def url
        "http://rails-bestpractices.com/posts/72-remove-empty-helpers"
      end

      def interesting_files
        HELPER_FILES
      end

      def interesting_nodes
        [:module]
      end

      # check the body of module node, if it is nil, then it should be removed.
      def start_module(node)
        if s(:bodystmt, s(:stmts_add, s(:stmts_new), s(:void_stmt)), nil, nil, nil) == node.body
          add_error "remove empty helpers", node.file, node.line
        end
      end
    end
  end
end

Version data entries

5 entries across 5 versions & 1 rubygems

Version Path
rails_best_practices-1.3.0 lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-1.2.0 lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-1.1.0 lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-1.0.1 lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-1.0.0 lib/rails_best_practices/reviews/remove_empty_helpers_review.rb