Sha256: d8974f6c51383543b638ccd082c0bbdd302751c6d9478489c61a147abb575477

Contents?: true

Size: 1.88 KB

Versions: 18

Compression:

Stored size: 1.88 KB

Contents

#
# Copyright:: 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

module RuboCop
  module Cop
    module Chef
      # Make sure a cookbook doesn't depend on itself. This will fail on Chef Infra Client 13+
      #
      # @example
      #
      #   # bad
      #   name 'foo'
      #   depends 'foo'
      #
      #   # good
      #   name 'foo'
      #
      module ChefCorrectness
        class CookbooksDependsOnSelf < Cop
          include RangeHelp

          MSG = 'A cookbook cannot depend on itself. This will fail on Chef Infra Client 13+'.freeze

          def_node_search :dependencies, '(send nil? :depends str ...)'
          def_node_matcher :cb_name?, '(send nil? :name str ...)'

          def on_send(node)
            cb_name?(node) do
              dependencies(processed_source.ast).each do |dep|
                if dep.arguments == node.arguments
                  node = dep # set our dependency node as the node for autocorrecting later
                  add_offense(node, location: dep.source_range, message: MSG, severity: :refactor)
                end
              end
            end
          end

          def autocorrect(node)
            lambda do |corrector|
              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
            end
          end
        end
      end
    end
  end
end

Version data entries

18 entries across 18 versions & 1 rubygems

Version Path
cookstyle-6.11.4 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.10.2 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.9.0 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.8.0 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.7.3 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.6.9 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.5.3 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.4.4 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-5.23.0 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.3.4 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.2.9 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.2.5 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.1.6 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-6.0.19 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-5.22.6 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-5.21.9 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-5.20.0 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
cookstyle-5.19.9 lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb