# frozen_string_literal: true module RuboCop module Cop module Rails # This cop converts usages of `try!` to `&.`. It can also be configured # to convert `try`. It will convert code to use safe navigation if the # target Ruby version is set to 2.3+ # # @example # # ConvertTry: false # # bad # foo.try!(:bar) # foo.try!(:bar, baz) # foo.try!(:bar) { |e| e.baz } # # foo.try!(:[], 0) # # # good # foo.try(:bar) # foo.try(:bar, baz) # foo.try(:bar) { |e| e.baz } # # foo&.bar # foo&.bar(baz) # foo&.bar { |e| e.baz } # # # # ConvertTry: true # # bad # foo.try!(:bar) # foo.try!(:bar, baz) # foo.try!(:bar) { |e| e.baz } # foo.try(:bar) # foo.try(:bar, baz) # foo.try(:bar) { |e| e.baz } # # # good # foo&.bar # foo&.bar(baz) # foo&.bar { |e| e.baz } class SafeNavigation < Cop extend TargetRubyVersion include RangeHelp MSG = 'Use safe navigation (`&.`) instead of `%s`.'.freeze def_node_matcher :try_call, <<-PATTERN (send !nil? ${:try :try!} $_ ...) PATTERN minimum_target_ruby_version 2.3 def on_send(node) try_call(node) do |try_method, dispatch| return if try_method == :try && !cop_config['ConvertTry'] return unless dispatch.sym_type? && dispatch.value =~ /\w+[=!?]?/ add_offense(node, message: format(MSG, try: try_method)) end end def autocorrect(node) method_node, *params = *node.arguments method = method_node.source[1..-1] range = range_between(node.loc.dot.begin_pos, node.loc.expression.end_pos) lambda do |corrector| corrector.replace(range, replacement(method, params)) end end private def replacement(method, params) new_params = params.map(&:source).join(', ') if method.end_with?('=') "&.#{method[0...-1]} = #{new_params}" elsif params.empty? "&.#{method}" else "&.#{method}(#{new_params})" end end end end end end