# frozen_string_literal: true module RuboCop module Cop module Style # This cop (by default) checks for uses of methods Hash#has_key? and # Hash#has_value? where it enforces Hash#key? and Hash#value? # It is configurable to enforce the inverse, using `verbose` method # names also. # # @example EnforcedStyle: short (default) # # bad # Hash#has_key? # Hash#has_value? # # # good # Hash#key? # Hash#value? # # @example EnforcedStyle: verbose # # bad # Hash#key? # Hash#value? # # # good # Hash#has_key? # Hash#has_value? class PreferredHashMethods < Cop include ConfigurableEnforcedStyle MSG = 'Use `Hash#%s` instead of `Hash#%s`.'.freeze OFFENDING_SELECTORS = { short: %i[has_key? has_value?], verbose: %i[key? value?] }.freeze def on_send(node) return unless node.arguments.one? && offending_selector?(node.method_name) add_offense(node, location: :selector) end alias on_csend on_send def autocorrect(node) lambda do |corrector| corrector.replace(node.loc.selector, proper_method_name(node.loc.selector.source)) end end private def message(node) format(MSG, prefer: proper_method_name(node.method_name), current: node.method_name) end def proper_method_name(method_name) if style == :verbose "has_#{method_name}" else method_name.to_s.sub(/has_/, '') end end def offending_selector?(method_name) OFFENDING_SELECTORS[style].include?(method_name) end end end end end