Sha256: d37acd0ae6034dbb2fc2b24e02294f8190a7778046d5fc5c181baecc8126b436
Contents?: true
Size: 1.44 KB
Versions: 24
Compression:
Stored size: 1.44 KB
Contents
# encoding: utf-8
module RuboCop
module Cop
module Lint
# This cop checks for odd else block layout - like
# having an expression on the same line as the else keyword,
# which is usually a mistake.
#
# @example
#
# if something
# ...
# else do_this
# do_that
# end
class ElseLayout < Cop
def on_if(node)
# ignore ternary ops
return if node.loc.respond_to?(:question)
# ignore modifier ops & elsif nodes
return unless node.loc.end
check(node)
end
private
def check(node)
return unless node
if node.loc.respond_to?(:else) &&
node.loc.else &&
node.loc.else.is?('else')
_cond, _if_branch, else_branch = *node
return unless else_branch && else_branch.type == :begin
first_else_expr = else_branch.children.first
if first_else_expr.loc.expression.line == node.loc.else.line
add_offense(first_else_expr, :expression, message)
end
elsif node.loc.respond_to?(:keyword) &&
%w(if elsif).include?(node.loc.keyword.source)
_cond, _if_branch, else_branch = *node
check(else_branch)
end
end
def message
'Odd `else` layout detected. Did you mean to use `elsif`?'
end
end
end
end
end
Version data entries
24 entries across 24 versions & 2 rubygems