require 'spec_helper'

describe 'relative_classname_inclusion' do
  describe '(default)' do
    let(:msg) { 'class included by relative name' }

    context 'with fix disabled' do
      context 'when absolute names are used' do
        let(:code) do
          <<-EOS
          include ::foobar
          include('::foobar')
          include(foobar(baz))
          include(foobar('baz'))

          include ::foo, ::bar
          include('::foo', '::bar')

          class { '::foobar': }

          class foobar {
          }

          contain ::foobar
          contain('::foobar')
          contain(foobar(baz))
          contain(foobar('baz'))

          require ::foobar
          require('::foobar')
          require(foobar(baz))
          require(foobar('baz'))
          EOS
        end

        it 'should not detect any problems' do
          expect(problems).to have(0).problems
        end
      end

      context 'when relative names are used' do
        let(:code) do
          <<-EOS
          include foobar
          include(foobar)
          class { 'foobar': }
          contain foobar
          contain(foobar)
          require foobar
          require(foobar)
          EOS
        end

        it 'should detect 7 problems' do
          expect(problems).to have(7).problems
        end

        it 'should create warnings' do
          expect(problems).to contain_warning(msg).on_line(1).in_column(19)
          expect(problems).to contain_warning(msg).on_line(2).in_column(19)
          expect(problems).to contain_warning(msg).on_line(3).in_column(19)
          expect(problems).to contain_warning(msg).on_line(4).in_column(19)
          expect(problems).to contain_warning(msg).on_line(5).in_column(19)
          expect(problems).to contain_warning(msg).on_line(6).in_column(19)
          expect(problems).to contain_warning(msg).on_line(7).in_column(19)
        end
      end

      context 'when the require metadata parameter is used' do
        let(:code) do
          <<-EOS
          file { '/path':
            ensure  => present,
            require => Shellvar['http_proxy'],
          }
          EOS
        end

        it 'should detect no problems' do
          expect(problems).to have(0).problems
        end
      end

      context 'when require is a hash key' do
        let(:code) do
          <<-EOS
          $defaults = {
            require => Exec['apt_update'],
          }
          $defaults = {
            'require' => Exec['apt_update'],
          }
          EOS
        end

        it 'should detect no problems' do
          expect(problems).to have(0).problems
        end
      end
    end

    context 'with fix enabled' do
      before do
        PuppetLint.configuration.fix = true
      end

      after do
        PuppetLint.configuration.fix = false
      end

      context 'when absolute names are used' do
        let(:code) do
          <<-EOS
          include ::foobar
          include('::foobar')
          include(foobar(baz))
          include(foobar('baz'))

          include ::foo, ::bar
          include('::foo', '::bar')

          class { '::foobar': }

          class foobar {
          }

          contain ::foobar
          contain('::foobar')
          contain(foobar(baz))
          contain(foobar('baz'))

          require ::foobar
          require('::foobar')
          require(foobar(baz))
          require(foobar('baz'))
          EOS
        end

        it 'should not detect any problems' do
          expect(problems).to have(0).problems
        end
      end

      context 'when relative names are used' do
        let(:code) do
          <<-EOS
          include foobar
          include(foobar)
          class { 'foobar': }
          contain foobar
          contain(foobar)
          require foobar
          require(foobar)
          EOS
        end

        it 'should detect 7 problems' do
          expect(problems).to have(7).problems
        end

        it 'should fix the problems' do
          expect(problems).to contain_fixed(msg).on_line(1).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(2).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(3).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(4).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(5).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(6).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(7).in_column(19)
        end

        it 'should should add colons' do
          expect(manifest).to eq(
          <<-EOS
          include ::foobar
          include(::foobar)
          class { '::foobar': }
          contain ::foobar
          contain(::foobar)
          require ::foobar
          require(::foobar)
          EOS
          )
        end
      end
    end

    describe '(#12) behavior of lookup("foo", {merge => unique}).include' do
      let(:msg) { '(#12) class included with lookup("foo", {merge => unique}).include' }

      let(:code) do
        <<-EOS
        lookup(foo, {merge => unique}).include
        EOS
      end

      it 'should not detect any problems' do
        expect(problems).to have(0).problems
      end
    end
  end

  describe '(reversed)' do
    before do
      PuppetLint.configuration.absolute_classname_reverse = true
    end
    let(:msg) { 'class included by absolute name (::$class)' }

    context 'with fix disabled' do
      context 'when absolute names are used' do
        let(:code) do
          <<-EOS
          include ::foobar
          include('::foobar')
          include(foobar(baz))
          include(foobar('baz'))

          include ::foo, ::bar
          include('::foo', '::bar')

          class { '::foobar': }

          class foobar {
          }

          contain ::foobar
          contain('::foobar')
          contain(foobar(baz))
          contain(foobar('baz'))

          require ::foobar
          require('::foobar')
          require(foobar(baz))
          require(foobar('baz'))
          EOS
        end

        it 'should detect 11 problems' do
          expect(problems).to have(11).problems
        end

        it 'should create warnings' do
          expect(problems).to contain_warning(msg).on_line(1).in_column(19)
          expect(problems).to contain_warning(msg).on_line(2).in_column(19)
          expect(problems).to contain_warning(msg).on_line(6).in_column(19)
          expect(problems).to contain_warning(msg).on_line(6).in_column(26)
          expect(problems).to contain_warning(msg).on_line(7).in_column(19)
          expect(problems).to contain_warning(msg).on_line(7).in_column(28)
          expect(problems).to contain_warning(msg).on_line(9).in_column(19)
          expect(problems).to contain_warning(msg).on_line(14).in_column(19)
          expect(problems).to contain_warning(msg).on_line(15).in_column(19)
          expect(problems).to contain_warning(msg).on_line(19).in_column(19)
          expect(problems).to contain_warning(msg).on_line(20).in_column(19)
        end
      end

      context 'when relative names are used' do
        let(:code) do
          <<-EOS
          include foobar
          include(foobar)
          class { 'foobar': }
          contain foobar
          contain(foobar)
          require foobar
          require(foobar)
          EOS
        end

        it 'should not detect a problem' do
          expect(problems).to have(0).problems
        end
      end

      context 'when the require metadata parameter is used' do
        let(:code) do
          <<-EOS
          file { '/path':
            ensure  => present,
            require => Shellvar['http_proxy'],
          }
          EOS
        end

        it 'should detect no problems' do
          expect(problems).to have(0).problems
        end
      end

      context 'when require is a hash key' do
        let(:code) do
          <<-EOS
          $defaults = {
            require => Exec['apt_update'],
          }
          $defaults = {
            'require' => Exec['apt_update'],
          }
          EOS
        end

        it 'should detect no problems' do
          expect(problems).to have(0).problems
        end
      end
    end

    context 'with fix enabled' do
      before do
        PuppetLint.configuration.fix = true
      end

      after do
        PuppetLint.configuration.fix = false
      end

      context 'when absolute names are used' do
        let(:code) do
          <<-EOS
          include ::foobar
          include('::foobar')
          include(foobar(baz))
          include(foobar('baz'))

          include ::foo, ::bar
          include('::foo', '::bar')

          class { '::foobar': }

          class foobar {
          }

          contain ::foobar
          contain('::foobar')
          contain(foobar(baz))
          contain(foobar('baz'))

          require ::foobar
          require('::foobar')
          require(foobar(baz))
          require(foobar('baz'))
          EOS
        end

        it 'should detect 11 problems' do
          expect(problems).to have(11).problems
        end

        it 'should fix the problems' do
          expect(problems).to contain_fixed(msg).on_line(1).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(2).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(6).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(6).in_column(26)
          expect(problems).to contain_fixed(msg).on_line(7).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(7).in_column(28)
          expect(problems).to contain_fixed(msg).on_line(9).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(14).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(15).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(19).in_column(19)
          expect(problems).to contain_fixed(msg).on_line(20).in_column(19)
        end

        it 'should should remove colons' do
          expect(manifest).to eq(
          <<-EOS
          include foobar
          include('foobar')
          include(foobar(baz))
          include(foobar('baz'))

          include foo, bar
          include('foo', 'bar')

          class { 'foobar': }

          class foobar {
          }

          contain foobar
          contain('foobar')
          contain(foobar(baz))
          contain(foobar('baz'))

          require foobar
          require('foobar')
          require(foobar(baz))
          require(foobar('baz'))
          EOS
          )
        end
      end

      context 'when relative names are used' do
        let(:code) do
          <<-EOS
          include foobar
          include(foobar)
          class { 'foobar': }
          contain foobar
          contain(foobar)
          require foobar
          require(foobar)
          EOS
        end

        it 'should not detect any problems' do
          expect(problems).to have(0).problems
        end
      end
    end

    describe '(#12) behavior of lookup("foo", {merge => unique}).include' do
      let(:msg) { '(#12) class included with lookup("foo", {merge => unique}).include' }

      let(:code) do
        <<-EOS
        lookup(foo, {merge => unique}).include
        EOS
      end

      it 'should not detect any problems' do
        expect(problems).to have(0).problems
      end
    end
  end
end