Contents

require 'simplabs/excellent/checks/base'

module Simplabs

  module Excellent

    module Checks

      # This check reports code that uses +for+ loops as in:
      #
      #  for user in @users
      #    do_something(user)
      #  end
      #
      # The use of for loops in Ruby is contrary to the language's basic concept of iterators. The above statement would better be written as:
      #
      #  @users.each do |user|
      #    do_something(user)
      #  end
      #
      # ==== Applies to
      #
      # * +for+ loops
      class ForLoopCheck < Base

        def initialize #:nodoc:
          super
          @interesting_nodes = [:for]
        end

        def evaluate(context) #:nodoc:
          add_warning(context, 'For loop used.')
        end

      end

    end

  end

end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
simplabs-excellent-1.2.1	lib/simplabs/excellent/checks/for_loop_check.rb
simplabs-excellent-1.2.2	lib/simplabs/excellent/checks/for_loop_check.rb
simplabs-excellent-1.3.0	lib/simplabs/excellent/checks/for_loop_check.rb
simplabs-excellent-1.3.1	lib/simplabs/excellent/checks/for_loop_check.rb