Contents

require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_method_name')
require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')

include Reek
include Reek::Smells

describe UncommunicativeMethodName do
  before :each do
    @source_name = 'wallamalloo'
    @detector = UncommunicativeMethodName.new(@source_name)
  end

  it_should_behave_like 'SmellDetector'

  ['help', '+', '-', '/', '*'].each do |method_name|
    it "accepts the method name '#{method_name}'" do
      "def #{method_name}(fred) basics(17) end".should_not smell_of(UncommunicativeMethodName)
    end
  end

  ['x', 'x2', 'method2'].each do |method_name|
    context 'with a bad name' do
      before :each do
        src = 'def x() end'
        ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
        @smells = @detector.examine_context(ctx)
        @warning = @smells[0]
      end

      it_should_behave_like 'common fields set correctly'

      it 'reports the correct values' do
        @smells[0].smell[UncommunicativeMethodName::METHOD_NAME_KEY].should == 'x'
        @smells[0].lines.should == [1]
        @smells[0].context.should == 'x'
      end
    end
  end
end

Version data entries

8 entries across 8 versions & 1 rubygems

Version	Path
reek-1.3.1	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.3	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.2.13	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.2.12	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.2.11	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.2.10	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.2.9	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-1.2.8	spec/reek/smells/uncommunicative_method_name_spec.rb