Sha256: c84c4d5cd64247996f011fdd1f2743563c6fac2c261bba348d133042571b9351
Contents?: true
Size: 1.77 KB
Versions: 32
Compression:
Stored size: 1.77 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# Looks for uses of `each_with_object({}) { ... }`,
# `map { ... }.to_h`, and `Hash[map { ... }]` that are transforming
# an enumerable into a hash where the values are the original elements.
# Rails provides the `index_by` method for this purpose.
#
# @example
# # bad
# [1, 2, 3].each_with_object({}) { |el, h| h[foo(el)] = el }
# [1, 2, 3].to_h { |el| [foo(el), el] }
# [1, 2, 3].map { |el| [foo(el), el] }.to_h
# Hash[[1, 2, 3].collect { |el| [foo(el), el] }]
#
# # good
# [1, 2, 3].index_by { |el| foo(el) }
class IndexBy < Base
include IndexMethod
extend AutoCorrector
def_node_matcher :on_bad_each_with_object, <<~PATTERN
(block
(call _ :each_with_object (hash))
(args (arg $_el) (arg _memo))
(call (lvar _memo) :[]= $!`_memo (lvar _el)))
PATTERN
def_node_matcher :on_bad_to_h, <<~PATTERN
(block
(call _ :to_h)
(args (arg $_el))
(array $_ (lvar _el)))
PATTERN
def_node_matcher :on_bad_map_to_h, <<~PATTERN
(call
(block
(call _ {:map :collect})
(args (arg $_el))
(array $_ (lvar _el)))
:to_h)
PATTERN
def_node_matcher :on_bad_hash_brackets_map, <<~PATTERN
(send
(const {nil? cbase} :Hash)
:[]
(block
(call _ {:map :collect})
(args (arg $_el))
(array $_ (lvar _el))))
PATTERN
private
def new_method_name
'index_by'
end
end
end
end
end
Version data entries
32 entries across 31 versions & 6 rubygems