Sha256: c821e0a309c270addd9de0bc902461e3d5d62375c01eac903eafdff7c20d0316
Contents?: true
Size: 1.56 KB
Versions: 60
Compression:
Stored size: 1.56 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for circular argument references in optional keyword
# arguments and optional ordinal arguments.
#
# This cop mirrors a warning produced by MRI since 2.2.
#
# @example
#
# # bad
#
# def bake(pie: pie)
# pie.heat_up
# end
#
# @example
#
# # good
#
# def bake(pie:)
# pie.refrigerate
# end
#
# @example
#
# # good
#
# def bake(pie: self.pie)
# pie.feed_to(user)
# end
#
# @example
#
# # bad
#
# def cook(dry_ingredients = dry_ingredients)
# dry_ingredients.reduce(&:+)
# end
#
# @example
#
# # good
#
# def cook(dry_ingredients = self.dry_ingredients)
# dry_ingredients.combine
# end
class CircularArgumentReference < Cop
MSG = 'Circular argument reference - `%<arg_name>s`.'
def on_kwoptarg(node)
check_for_circular_argument_references(*node)
end
def on_optarg(node)
check_for_circular_argument_references(*node)
end
private
def check_for_circular_argument_references(arg_name, arg_value)
return unless arg_value.lvar_type?
return unless arg_value.to_a == [arg_name]
add_offense(arg_value, message: format(MSG, arg_name: arg_name))
end
end
end
end
end
Version data entries
60 entries across 41 versions & 5 rubygems