Sha256: c754f680cbfac54a6d46878a7f75d92539984d8e45787f6d4ec86c3abfc6f5eb
Contents?: true
Size: 1.94 KB
Versions: 19
Compression:
Stored size: 1.94 KB
Contents
# Pull Requests ## Checklist before Committing 1. `rake`: runs all linters and specs (you need Docker setup, see below) 2. Did you need any more tests for your change? 3. Did you document your change? Update the README.md? 4. Did you add a CHANGELOG.md entry? For non-doc fixes: * Provide changelog entry in the [unreleased section of the CHANGELOG.md](https://github.com/shakacode/react_on_rails/blob/master/CHANGELOG.md#unreleased). * Ensure CI passes and that you added a test that passes with the fix and fails without the fix. * Squash all commits down to one with a nice commit message *ONLY* once final review is given. Make sure this single commit is rebased on top of master. * Please address all code review comments. * Ensure that docs are updated accordingly if a feature is added. ## Commit Messages From [How to Write a Git Commit Message](http://chris.beams.io/posts/git-commit/) #### The seven rules of a great git commit message > Keep in mind: This has all been said before. 1. Separate subject from body with a blank line 1. Limit the subject line to 50 characters 1. Capitalize the subject line 1. Do not end the subject line with a period 1. Use the imperative mood in the subject line 1. Wrap the body at 72 characters 1. Use the body to explain what and why vs. how ## Doc Changes When making doc changes, we want the change to work on both the gitbook and the regular github site. The issue is that non-doc files will not go to the gitbook site, so doc references to non doc files must use the github URL. ### Links to other docs: * When making references to doc files, use a relative URL path like: `[Installation Overview](https://www.shakacode.com/react-on-rails/docs/additional-details/manual-installation-overview/)` * When making references to source code files, use a full url path like: `[spec/dummy/config/initializers/react_on_rails.rb](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy/config/initializers/react_on_rails.rb)`
Version data entries
19 entries across 19 versions & 1 rubygems