Sha256: c694413718fb03c4a0bb5b368afc849214559337dfee6d86db546fd3d96e5c72
Contents?: true
Size: 1.39 KB
Versions: 17
Compression:
Stored size: 1.39 KB
Contents
require 'spec_helper'
module RailsBestPractices
module Reviews
describe MoveCodeIntoControllerReview do
let(:runner) { Core::Runner.new(reviews: MoveCodeIntoControllerReview.new) }
it "should move code into controller for method call" do
content = <<-EOF
<% Post.find(:all).each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
end
it "should move code into controller for assign" do
content = <<-EOF
<% @posts = Post.all %>
<% @posts.each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
end
it "should not move code into controller" do
content = <<-EOF
<% @posts.each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
runner.should have(0).errors
end
end
end
end
Version data entries
17 entries across 17 versions & 1 rubygems