Sha256: c580af1c67664ca203ffc03b3d7869e3c0702bbb47cb1bb2232165e94eabfb70

Contents?: true

Size: 1003 Bytes

Versions: 17

Compression:

Stored size: 1003 Bytes

Contents

require 'spec_helper'

describe RailsBestPractices::Reviews::MoveCodeIntoHelperReview do
  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveCodeIntoHelperReview.new('array_count' => 2)) }

  it "should move code into helper" do
    content = <<-EOF
    <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
                                                [t(:published), "published"]],
                                               params[:default_state] ) %>
    EOF
    runner.review('app/views/posts/show.html.erb', content)
    runner.should have(1).errors
    runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)"
  end

  it "should not move code into helper with simple arguments" do
    content = <<-EOF
    <%= select_tag :state, options_for_select( Post.STATES ) %>
    EOF
    runner.review('app/views/posts/show.html.erb', content)
    runner.should have(0).errors
  end
end

Version data entries

17 entries across 17 versions & 2 rubygems

Version Path
rails_best_practices-gorgeouscode-1.0.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.9.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.8.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.7.2 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.7.1 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.7.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.6.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.5.3 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.5.2 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.5.1 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.5.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.4.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.3.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.2.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.1.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.0.1 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb
rails_best_practices-1.0.0 spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb