Sha256: c4c77a338bc8f0e9ea66518799e4d6d778f8cb6d6059f007baeb39dcba8fd137
Contents?: true
Size: 1.79 KB
Versions: 20
Compression:
Stored size: 1.79 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop enforces the use of `Object#instance_of?` instead of class comparison
# for equality.
#
# @example
# # bad
# var.class == Date
# var.class.equal?(Date)
# var.class.eql?(Date)
# var.class.name == 'Date'
#
# # good
# var.instance_of?(Date)
#
class ClassEqualityComparison < Base
include RangeHelp
include IgnoredMethods
extend AutoCorrector
MSG = 'Use `instance_of?(%<class_name>s)` instead of comparing classes.'
RESTRICT_ON_SEND = %i[== equal? eql?].freeze
def_node_matcher :class_comparison_candidate?, <<~PATTERN
(send
{$(send _ :class) (send $(send _ :class) :name)}
{:== :equal? :eql?} $_)
PATTERN
def on_send(node)
def_node = node.each_ancestor(:def, :defs).first
return if def_node && ignored_method?(def_node.method_name)
class_comparison_candidate?(node) do |receiver_node, class_node|
range = offense_range(receiver_node, node)
class_name = class_name(class_node, node)
add_offense(range, message: format(MSG, class_name: class_name)) do |corrector|
corrector.replace(range, "instance_of?(#{class_name})")
end
end
end
private
def class_name(class_node, node)
if node.children.first.method?(:name)
class_node.source.delete('"').delete("'")
else
class_node.source
end
end
def offense_range(receiver_node, node)
range_between(receiver_node.loc.selector.begin_pos, node.source_range.end_pos)
end
end
end
end
end
Version data entries
20 entries across 20 versions & 1 rubygems