Sha256: c1ba79de95d2475d78feffa86f290061a1afbe3e65a6ffc7f1bd1cc63263aaa9
Contents?: true
Size: 1.68 KB
Versions: 11
Compression:
Stored size: 1.68 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for nested method definitions.
#
# @example
# # `bar` definition actually produces methods in the same scope
# # as the outer `foo` method. Furthermore, the `bar` method
# # will be redefined every time `foo` is invoked.
# def foo
# def bar
# end
# end
#
class NestedMethodDefinition < Cop
include OnMethodDef
extend RuboCop::NodePattern::Macros
MSG = 'Method definitions must not be nested. ' \
'Use `lambda` instead.'.freeze
def on_method_def(node, _method_name, _args, _body)
find_nested_defs(node) do |nested_def_node|
add_offense(nested_def_node, :expression)
end
end
def find_nested_defs(node, &block)
node.each_child_node do |child|
if child.def_type?
yield child
elsif child.defs_type?
subject, = *child
next if subject.lvar_type?
yield child
elsif !ignored_child?(child)
find_nested_defs(child, &block)
end
end
end
private
def ignored_child?(child)
eval_call?(child) || class_or_module_or_struct_new_call?(child)
end
def_node_matcher :eval_call?, <<-PATTERN
(block (send _ {:instance_eval :class_eval :module_eval} ...) ...)
PATTERN
def_node_matcher :class_or_module_or_struct_new_call?, <<-PATTERN
(block (send (const nil {:Class :Module :Struct}) :new ...) ...)
PATTERN
end
end
end
end
Version data entries
11 entries across 11 versions & 2 rubygems