Sha256: c165d19e5c8344f00cabe625d37d28c2370a315ab386f865052a272166aeb152

Contents?: true

Size: 1.11 KB

Versions: 34

Compression:

Stored size: 1.11 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Minitest
      # Enforces the test to use `assert_silent { ... }`
      # instead of using `assert_output('', '') { ... }`.
      #
      # @example
      #   # bad
      #   assert_output('', '') { puts object.do_something }
      #
      #   # good
      #   assert_silent { puts object.do_something }
      #
      class AssertSilent < Base
        extend AutoCorrector

        MSG = 'Prefer using `assert_silent`.'

        def_node_matcher :assert_silent_candidate?, <<~PATTERN
          (block
            (send nil? :assert_output
              #empty_string?
              #empty_string?)
            ...)
        PATTERN

        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
          return unless assert_silent_candidate?(node)

          send_node = node.send_node

          add_offense(send_node) do |corrector|
            corrector.replace(send_node, 'assert_silent')
          end
        end

        private

        def empty_string?(node)
          node.str_type? && node.value.empty?
        end
      end
    end
  end
end

Version data entries

34 entries across 34 versions & 2 rubygems

Version Path
rubocop-minitest-0.37.1 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.37.0 lib/rubocop/cop/minitest/assert_silent.rb
tailscale_middleware-0.0.3 vendor/cache/ruby/3.4.0/gems/rubocop-minitest-0.36.0/lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.36.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.35.1 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.35.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.34.5 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.34.4 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.34.3 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.34.2 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.34.1 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.34.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.33.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.32.2 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.32.1 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.32.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.31.1 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.31.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.30.0 lib/rubocop/cop/minitest/assert_silent.rb
rubocop-minitest-0.29.0 lib/rubocop/cop/minitest/assert_silent.rb