Sha256: c062116146da2219d9d639c9fbd893ab90f9ee979e554d6fa56a0624abe4a778

Contents?: true

Size: 1 KB

Versions: 37

Compression:

Stored size: 1 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for `rescue` blocks targeting the Exception class.
      #
      # @example
      #
      #   # bad
      #
      #   begin
      #     do_something
      #   rescue Exception
      #     handle_exception
      #   end
      #
      # @example
      #
      #   # good
      #
      #   begin
      #     do_something
      #   rescue ArgumentError
      #     handle_exception
      #   end
      class RescueException < Base
        MSG = 'Avoid rescuing the `Exception` class. ' \
              'Perhaps you meant to rescue `StandardError`?'

        def on_resbody(node)
          return unless node.children.first

          rescue_args = node.children.first.children
          return unless rescue_args.any? { |a| targets_exception?(a) }

          add_offense(node)
        end

        def targets_exception?(rescue_arg_node)
          rescue_arg_node.const_name == 'Exception'
        end
      end
    end
  end
end

Version data entries

37 entries across 37 versions & 3 rubygems

Version Path
plaid-14.13.0 vendor/bundle/ruby/3.0.0/gems/rubocop-0.91.1/lib/rubocop/cop/lint/rescue_exception.rb
plaid-14.12.1 vendor/bundle/ruby/3.0.0/gems/rubocop-0.91.1/lib/rubocop/cop/lint/rescue_exception.rb
plaid-14.12.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/lint/rescue_exception.rb
plaid-14.11.1 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/lint/rescue_exception.rb
plaid-14.10.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/lint/rescue_exception.rb
plaid-14.7.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.12.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.12.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.11.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.10.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.9.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.9.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.8.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.8.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.7.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.6.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.6.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.5.2 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.5.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.5.0 lib/rubocop/cop/lint/rescue_exception.rb