# frozen_string_literal: true module RuboCop module Cop module Style # This cop checks for the use of a method, the result of which # would be a literal, like an empty array, hash or string. class EmptyLiteral < Cop include FrozenStringLiteral ARR_MSG = 'Use array literal `[]` instead of `Array.new`.'.freeze HASH_MSG = 'Use hash literal `{}` instead of `Hash.new`.'.freeze STR_MSG = 'Use string literal `%s` instead of `String.new`.'.freeze # Empty array node # # (send # (const nil :Array) :new) ARRAY_NODE = s(:send, s(:const, nil, :Array), :new) # Empty hash node # # (send # (const nil :Hash) :new) HASH_NODE = s(:send, s(:const, nil, :Hash), :new) # Empty string node # # (send # (const nil :String) :new) STR_NODE = s(:send, s(:const, nil, :String), :new) def on_send(node) case node when ARRAY_NODE add_offense(node, :expression, ARR_MSG) when HASH_NODE # If Hash.new takes a block, it can't be changed to {}. return if node.parent && node.parent.block_type? add_offense(node, :expression, HASH_MSG) when STR_NODE return if frozen_string_literals_enabled?(processed_source) add_offense(node, :expression, format(STR_MSG, preferred_string_literal)) end end def autocorrect(node) name = case node when ARRAY_NODE '[]' when HASH_NODE # `some_method {}` is not same as `some_method Hash.new` # because the braces are interpreted as a block, so we avoid # the correction. Parentheses around the arguments would # solve the problem, but we let the user add those manually. return if first_arg_in_method_call_without_parentheses?(node) '{}' when STR_NODE preferred_string_literal end ->(corrector) { corrector.replace(node.source_range, name) } end private def preferred_string_literal enforce_double_quotes? ? '""' : "''" end def enforce_double_quotes? string_literals_config['EnforcedStyle'] == 'double_quotes' end def string_literals_config config.for_cop('Style/StringLiterals') end def first_arg_in_method_call_without_parentheses?(node) return false unless node.parent && node.parent.send_type? _receiver, _method_name, *args = *node.parent node.object_id == args.first.object_id && !parentheses?(node.parent) end end end end end