Contents

module RuboCop
  module Cop
    module RSpec
      # Checks invalid usage for predicate matcher.
      #
      # Predicate matcher does not need a question.
      # This cop checks an unnecessary question in predicate matcher.
      #
      # @example
      #
      #   # bad
      #   expect(foo).to be_something?
      #
      #   # good
      #   expect(foo).to be_something
      class InvalidPredicateMatcher < Cop
        MSG = 'Omit `?` from `%<matcher>s`.'.freeze

        def_node_matcher :invalid_predicate_matcher?, <<-PATTERN
          (send (send nil :expect ...) {:to :not_to :to_not} $(send nil #predicate?))
        PATTERN

        def on_send(node)
          invalid_predicate_matcher?(node) do |predicate|
            add_offense(predicate, :expression)
          end
        end

        private

        def predicate?(name)
          name = name.to_s
          name.start_with?('be_', 'have_') && name.end_with?('?')
        end

        def message(predicate)
          format(MSG, matcher: predicate.method_name)
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
rubocop-rspec-1.18.0	lib/rubocop/cop/rspec/invalid_predicate_matcher.rb
rubocop-rspec-1.17.1	lib/rubocop/cop/rspec/invalid_predicate_matcher.rb
rubocop-rspec-1.17.0	lib/rubocop/cop/rspec/invalid_predicate_matcher.rb
rubocop-rspec-1.16.0	lib/rubocop/cop/rspec/invalid_predicate_matcher.rb