Sha256: bcae925fa2147d1739088ea3affbbf7c7f15a06f1b3a17453510de6d5ffd7bdf
Contents?: true
Size: 1.36 KB
Versions: 6
Compression:
Stored size: 1.36 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# This cop enforces the test to use `assert_empty`
# instead of using `assert_equal([], object)`.
#
# @example
# # bad
# assert_equal([], object)
# assert_equal({}, object)
#
# # good
# assert_empty(object)
#
class AssertEmptyLiteral < Base
include ArgumentRangeHelper
extend AutoCorrector
MSG = 'Prefer using `assert_empty(%<arguments>s)` over ' \
'`assert_equal(%<literal>s, %<arguments>s)`.'
RESTRICT_ON_SEND = %i[assert_equal].freeze
def_node_matcher :assert_equal_with_empty_literal, <<~PATTERN
(send nil? :assert_equal ${hash array} $...)
PATTERN
def on_send(node)
assert_equal_with_empty_literal(node) do |literal, matchers|
return unless literal.values.empty?
args = matchers.map(&:source).join(', ')
message = format(MSG, literal: literal.source, arguments: args)
add_offense(node, message: message) do |corrector|
object = matchers.first
corrector.replace(node.loc.selector, 'assert_empty')
corrector.replace(first_and_second_arguments_range(node), object.source)
end
end
end
end
end
end
end
Version data entries
6 entries across 6 versions & 1 rubygems