Sha256: bb9a3c7f73d4a972fa251c9d7f30985a399f33c977c01462d3e1b262a3a18381

Contents?: true

Size: 1.21 KB

Versions: 16

Compression:

Stored size: 1.21 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks for lambdas that always return nil, which can be replaced
      # with an empty lambda instead.
      #
      # @example
      #   # bad
      #   -> { nil }
      #
      #   lambda do
      #     next nil
      #   end
      #
      #   # good
      #   -> {}
      #
      #   lambda do
      #   end
      #
      #   -> (x) { nil if x }
      #
      class NilLambda < Base
        extend AutoCorrector
        include RangeHelp

        MSG = 'Use an empty lambda instead of always returning nil.'

        def_node_matcher :nil_return?, <<~PATTERN
          { ({return next break} nil) (nil) }
        PATTERN

        def on_block(node)
          return unless node.lambda?
          return unless nil_return?(node.body)

          add_offense(node) do |corrector|
            range = if node.single_line?
                      range_with_surrounding_space(range: node.body.loc.expression)
                    else
                      range_by_whole_lines(node.body.loc.expression, include_final_newline: true)
                    end

            corrector.remove(range)
          end
        end
      end
    end
  end
end

Version data entries

16 entries across 16 versions & 1 rubygems

Version Path
rubocop-1.10.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.9.1 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.9.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.8.1 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.8.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.7.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.6.1 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.6.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.5.2 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.5.1 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.5.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.4.2 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.4.1 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.4.0 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.3.1 lib/rubocop/cop/style/nil_lambda.rb
rubocop-1.3.0 lib/rubocop/cop/style/nil_lambda.rb