Contents

# frozen_string_literal: true

require 'rubocop'

module RuboCop
  module Cop
    module Standard
      class RailsControllerRenderShorthand < Cop
        MSG = 'Prefer `render` template shorthand'

        def_node_matcher :render_with_options?, <<-PATTERN
          (send nil? :render (hash $...))
        PATTERN

        def_node_matcher :action_key?, <<-PATTERN
          (pair (sym {:action :template}) $({str sym} _))
        PATTERN

        def_node_matcher :str, <<-PATTERN
          ({str sym} $_)
        PATTERN

        def investigate(*)
          @autocorrect = {}
        end

        def autocorrect(node)
          @autocorrect[node]
        end

        def on_send(node)
          return unless (option_pairs = render_with_options?(node))

          option_pairs.each do |pair|
            next unless (value_node = action_key?(pair))

            comma = option_pairs.length > 1 ? ', ' : ''
            corrected_source = node.source
                                   .sub(/#{pair.source}(,\s*)?/, '')
                                   .sub('render ', "render \"#{str(value_node)}\"#{comma}")

            @autocorrect[node] = lambda do |corrector|
              corrector.replace(node.source_range, corrected_source)
            end
            add_offense(node, location: :expression, message: "Use `#{corrected_source}` instead")
          end
        end
      end
    end
  end
end

Version data entries

12 entries across 12 versions & 1 rubygems

Version	Path
rubocop-standard-4.2.0	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-4.1.0	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-4.0.4	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-4.0.3	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-4.0.2	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-4.0.1	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-4.0.0	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-3.2.0	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-3.1.2	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-3.1.1	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-3.1.0	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb
rubocop-standard-3.0.0	lib/rubocop/cop/standard/rails/rails_controller_render_shorthand.rb