Contents

#
# Copyright:: Copyright 2019-2019, Chef Software Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      # The node.set_unless method has been removed in Chef-13 and must be replaced by node.normal_unless.
      #
      # Note that node.normal_unless keeps the semantics identical, but the use of node.normal is
      # also discouraged.
      #
      # @example
      #
      #   # bad
      #   node.set_unless['foo'] = true
      #
      #   # good
      #   node.normal_unless['foo'] = true
      #
      class NodeSetUnless < Cop
        MSG = 'Do not use node.set_unless. Replace with node.normal_unless to keep identical behavior.'.freeze

        def_node_matcher :node_set_unless?, <<-PATTERN
          (send (send _ :node) $:set_unless)
        PATTERN

        def on_send(node)
          node_set_unless?(node) do
            add_offense(node, location: :selector, message: MSG, severity: :refactor)
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            corrector.replace(node.loc.selector, 'normal_unless')
          end
        end
      end
    end
  end
end

Version data entries

3 entries across 3 versions & 1 rubygems

Version	Path
cookstyle-5.4.13	lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-5.3.6	lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-5.2.17	lib/rubocop/cop/chef/deprecation/node_set_unless.rb