Sha256: b8320db3a1494fb3502bafd5a315b9506201ab5cb6b12ef3472c322a9bf32e2e
Contents?: true
Size: 1.23 KB
Versions: 7
Compression:
Stored size: 1.23 KB
Contents
# encoding: utf-8
require 'rails_best_practices/reviews/review'
module RailsBestPractices
module Reviews
# Review a controller file to make sure using simplified syntax for render.
#
# See the best practice details here http://rails-bestpractices.com/posts/62-simplify-render-in-controllers.
#
# Implementation:
#
# Review process:
# check all render method calls in controller files,
# if there is a key 'action', 'template' or 'file' in the argument,
# then they should be replaced by simplified syntax.
class SimplifyRenderInControllersReview < Review
def url
"http://rails-bestpractices.com/posts/62-simplify-render-in-controllers"
end
def interesting_nodes
[:call]
end
def interesting_files
CONTROLLER_FILES
end
# check call node in the controller file,
# if its message is render and the arguments contain a key action, template or file,
# then it should be replaced by simplified syntax.
def start_call(call_node)
if :render == call_node.message && call_node.arguments[1].to_s =~ /"(action|template|file)" =>/
add_error 'simplify render in controllers'
end
end
end
end
end
Version data entries
7 entries across 7 versions & 2 rubygems