Sha256: b534cc30a5dd04a33378c17c9cb266cd8095c8cc079bc9d073de972960b8eddb
Contents?: true
Size: 1.78 KB
Versions: 6794
Compression:
Stored size: 1.78 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# This cop identifies the use of `Regexp#match` or `String#match`, which
# returns `#<MatchData>`/`nil`. The return value of `=~` is an integral
# index/`nil` and is more performant.
#
# @example
# # bad
# do_something if str.match(/regex/)
# while regex.match('str')
# do_something
# end
#
# # good
# method(str =~ /regex/)
# return value unless regex =~ 'str'
class RedundantMatch < Cop
MSG = 'Use `=~` in places where the `MatchData` returned by ' \
'`#match` will not be used.'.freeze
# 'match' is a fairly generic name, so we don't flag it unless we see
# a string or regexp literal on one side or the other
def_node_matcher :match_call?, <<-PATTERN
{(send {str regexp} :match _)
(send !nil? :match {str regexp})}
PATTERN
def_node_matcher :only_truthiness_matters?, <<-PATTERN
^({if while until case while_post until_post} equal?(%0) ...)
PATTERN
def on_send(node)
return unless match_call?(node) &&
(!node.value_used? || only_truthiness_matters?(node)) &&
!(node.parent && node.parent.block_type?)
add_offense(node)
end
def autocorrect(node)
# Regexp#match can take a second argument, but this cop doesn't
# register an offense in that case
return unless node.first_argument.regexp_type?
new_source =
node.receiver.source + ' =~ ' + node.first_argument.source
->(corrector) { corrector.replace(node.source_range, new_source) }
end
end
end
end
end
Version data entries
6,794 entries across 6,788 versions & 26 rubygems