Sha256: b5039ea96b084e160be42d6328601bbd14a12491427d30ddb1b6e485970f2eb6
Contents?: true
Size: 1.96 KB
Versions: 17
Compression:
Stored size: 1.96 KB
Contents
require 'spec_helper'
describe RailsBestPractices::Reviews::SimplifyRenderInControllersReview do
let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::SimplifyRenderInControllersReview.new) }
it "should simplify render action view" do
content =<<-EOF
def edit
render :action => :edit
end
EOF
runner.review("app/controllers/posts_controller.rb", content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
end
it "should simplify render actions's template" do
content =<<-EOF
def edit
render :template => 'books/edit'
end
EOF
runner.review("app/controllers/posts_controller.rb", content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
end
it "should simplify render an arbitrary file" do
content =<<-EOF
def edit
render :file => '/path/to/rails/app/views/books/edit'
end
EOF
runner.review("app/controllers/posts_controller.rb", content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
end
it "should not simplify render action view" do
content =<<-EOF
render :edit
EOF
runner.review("app/controllers/posts_controller", content)
runner.should have(0).errors
end
it "should not simplify render actions's template" do
content =<<-EOF
def edit
render 'books/edit'
end
EOF
runner.review("app/controllers/posts_controller.rb", content)
runner.should have(0).errors
end
it "should not simplify render an arbitrary file" do
content =<<-EOF
def edit
render '/path/to/rails/app/views/books/edit'
end
EOF
runner.review("app/controllers/posts_controller.rb", content)
runner.should have(0).errors
end
end
Version data entries
17 entries across 17 versions & 2 rubygems