Contents

# encoding: utf-8

module Rubocop
  module Cop
    module IfThenElse
      def on_if(node)
        check(node)
        super
      end

      def on_unless(node)
        check(node)
        super
      end

      def check(node)
        # We won't check modifier or ternary conditionals.
        if node.loc.expression.source =~ /\A(if|unless)\b/
          line = offending_line(node)
          add_offence(:convention, line, error_message) if line
        end
      end
    end

    class IfWithSemicolon < Cop
      include IfThenElse

      def offending_line(node)
        if node.loc.begin && node.loc.begin.source == ';'
          node.loc.begin.line
        end
      end

      def error_message
        'Never use if x; Use the ternary operator instead.'
      end
    end

    class MultilineIfThen < Cop
      include IfThenElse

      def offending_line(node)
        condition, body = *node
        next_thing = if body && body.loc.expression
                       body.loc.expression.begin
                     else
                       node.loc.end # No body, use "end".
                     end
        right_after_cond =
          Parser::Source::Range.new(next_thing.source_buffer,
                                    condition.loc.expression.end.end_pos,
                                    next_thing.begin_pos)
        if right_after_cond.source =~ /\A\s*then\s*(#.*)?\s*\n/
          node.loc.expression.begin.line
        end
      end

      def error_message
        'Never use then for multi-line if/unless.'
      end
    end

    class OneLineConditional < Cop
      include IfThenElse

      def offending_line(node)
        node.loc.expression.line unless node.loc.expression.source =~ /\n/
      end

      def error_message
        'Favor the ternary operator (?:) over if/then/else/end constructs.'
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
rubocop-0.8.3	lib/rubocop/cop/if_then_else.rb
rubocop-0.8.2	lib/rubocop/cop/if_then_else.rb