Contents

require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')

describe Simplabs::Excellent::Checks::GlobalVariableCheck do

  before(:each) do
    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::GlobalVariableCheck.new)
  end

  describe '#evaluate' do

    it 'should reject global variables' do
      code = <<-END
        $foo = 'bar'
      END
      @excellent.check_code(code)
      warnings = @excellent.warnings

      warnings.should_not be_empty
      warnings[0].info.should        == { :variable => 'foo' }
      warnings[0].line_number.should == 1
      warnings[0].message.should     == 'Global variable foo used.'
    end

    it 'should also work in modules' do
      code = <<-END
        module Outer
          module Inner
            class Class
              $foo = 'bar'
            end
          end
        end
      END
      @excellent.check_code(code)
      warnings = @excellent.warnings

      warnings.should_not be_empty
      warnings[0].info.should        == { :variable => 'foo' }
      warnings[0].line_number.should == 4
      warnings[0].message.should     == 'Global variable foo used.'
    end

    it 'should also work for global variables that occur within methods' do
      code = <<-END
        module Outer
          module Inner
            class Class
              def method
                $foo == 'bar'
              end
            end
          end
        end
      END
      @excellent.check_code(code)
      warnings = @excellent.warnings

      warnings.should_not be_empty
      warnings[0].info.should        == { :variable => 'foo' }
      warnings[0].line_number.should == 5
      warnings[0].message.should     == 'Global variable foo used.'
    end

  end

end

Version data entries

7 entries across 7 versions & 2 rubygems

Version	Path
simplabs-excellent-1.5.2	spec/checks/global_variable_check_spec.rb
simplabs-excellent-1.5.3	spec/checks/global_variable_check_spec.rb
excellent-1.7.2	spec/checks/global_variable_check_spec.rb
excellent-1.7.1	spec/checks/global_variable_check_spec.rb
excellent-1.7.0	spec/checks/global_variable_check_spec.rb
excellent-1.6.0	spec/checks/global_variable_check_spec.rb
excellent-1.5.4	spec/checks/global_variable_check_spec.rb