Sha256: b19a5956afadcf36af7bc95006f994cb7a59bed4150c65f38bfa2750ea2304c4
Contents?: true
Size: 1.82 KB
Versions: 24
Compression:
Stored size: 1.82 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for ambiguous block association with method
# when param passed without parentheses.
#
# @example
#
# # bad
# some_method a { |val| puts val }
#
# @example
#
# # good
# # With parentheses, there's no ambiguity.
# some_method(a { |val| puts val })
# # or (different meaning)
# some_method(a) { |val| puts val }
#
# # good
# # Operator methods require no disambiguation
# foo == bar { |b| b.baz }
#
# # good
# # Lambda arguments require no disambiguation
# foo = ->(bar) { bar.baz }
class AmbiguousBlockAssociation < Base
MSG = 'Parenthesize the param `%<param>s` to make sure that the ' \
'block will be associated with the `%<method>s` method ' \
'call.'
def on_send(node)
return unless node.arguments?
return unless ambiguous_block_association?(node)
return if node.parenthesized? ||
node.last_argument.lambda? || allowed_method?(node)
message = message(node)
add_offense(node, message: message)
end
alias on_csend on_send
private
def ambiguous_block_association?(send_node)
send_node.last_argument.block_type? &&
!send_node.last_argument.send_node.arguments?
end
def allowed_method?(node)
node.assignment? || node.operator_method? || node.method?(:[])
end
def message(send_node)
block_param = send_node.last_argument
format(MSG, param: block_param.source,
method: block_param.send_node.source)
end
end
end
end
end
Version data entries
24 entries across 24 versions & 1 rubygems