Sha256: b1339fa1ae389af1fcdb8fcc7b23357721bf972ad20a56757c90aca1cd9a3d35

Contents?: true

Size: 1.29 KB

Versions: 53

Compression:

Stored size: 1.29 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Rails
      # Checks for redundant `travel_back` calls.
      # Since Rails 5.2, `travel_back` is automatically called at the end of the test.
      #
      # @example
      #
      #   # bad
      #   def teardown
      #     do_something
      #     travel_back
      #   end
      #
      #   # good
      #   def teardown
      #     do_something
      #   end
      #
      #   # bad
      #   after do
      #     do_something
      #     travel_back
      #   end
      #
      #   # good
      #   after do
      #     do_something
      #   end
      #
      class RedundantTravelBack < Base
        include RangeHelp
        extend AutoCorrector
        extend TargetRailsVersion

        minimum_target_rails_version 5.2

        MSG = 'Redundant `travel_back` detected.'
        RESTRICT_ON_SEND = %i[travel_back].freeze

        def on_send(node)
          return unless node.each_ancestor(:def, :block).any? do |ancestor|
            method_name = ancestor.def_type? ? :teardown : :after

            ancestor.method?(method_name)
          end

          add_offense(node) do |corrector|
            corrector.remove(range_by_whole_lines(node.source_range, include_final_newline: true))
          end
        end
      end
    end
  end
end

Version data entries

53 entries across 50 versions & 8 rubygems

Version Path
rubocop-rails-2.30.3 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.30.2 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.30.1 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.30.0 lib/rubocop/cop/rails/redundant_travel_back.rb
tailscale_middleware-0.0.3 vendor/cache/ruby/3.4.0/gems/rubocop-rails-2.29.1/lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.29.1 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.29.0 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.28.0 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.27.0 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.26.2 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.26.1 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.26.0 lib/rubocop/cop/rails/redundant_travel_back.rb
blacklight-spotlight-3.6.0.beta8 vendor/bundle/ruby/3.2.0/gems/rubocop-rails-2.25.1/lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.25.1 lib/rubocop/cop/rails/redundant_travel_back.rb
cm-admin-1.5.22 vendor/bundle/ruby/3.3.0/gems/rubocop-rails-2.15.2/lib/rubocop/cop/rails/redundant_travel_back.rb
cm-admin-1.5.21 vendor/bundle/ruby/3.3.0/gems/rubocop-rails-2.15.2/lib/rubocop/cop/rails/redundant_travel_back.rb
cm-admin-1.5.20 vendor/bundle/ruby/3.3.0/gems/rubocop-rails-2.15.2/lib/rubocop/cop/rails/redundant_travel_back.rb
katalyst-govuk-formbuilder-1.9.2 vendor/bundle/ruby/3.3.0/gems/rubocop-rails-2.25.0/lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.24.1 lib/rubocop/cop/rails/redundant_travel_back.rb
rubocop-rails-2.24.0 lib/rubocop/cop/rails/redundant_travel_back.rb