Contents

require_relative '../../spec_helper'
require_lib 'reek/smell_detectors/base_detector'
require_lib 'reek/smell_detectors/duplicate_method_call'

RSpec.describe Reek::SmellDetectors::BaseDetector do
  describe '.todo_configuration_for' do
    it 'returns exclusion configuration for the given smells' do
      smell = build_smell_warning(smell_type: 'Foo', context: 'Foo#bar')
      result = described_class.todo_configuration_for([smell])
      expect(result).to eq('BaseDetector' => { 'exclude' => ['Foo#bar'] })
    end

    it 'merges identical contexts' do
      smell = build_smell_warning(smell_type: 'Foo', context: 'Foo#bar')
      result = described_class.todo_configuration_for([smell, smell])
      expect(result).to eq('BaseDetector' => { 'exclude' => ['Foo#bar'] })
    end

    context 'with default exclusions present' do
      let(:subclass) { Reek::SmellDetectors::TooManyStatements }

      it 'includes default exclusions' do
        smell = build_smell_warning(smell_type: 'TooManyStatements', context: 'Foo#bar')
        result = subclass.todo_configuration_for([smell])

        aggregate_failures do
          expect(subclass.default_config['exclude']).to eq ['initialize']
          expect(result).to eq('TooManyStatements' => { 'exclude' => ['initialize', 'Foo#bar'] })
        end
      end
    end
  end

  describe '.to_detector' do
    it 'returns the right detector' do
      expect(described_class.to_detector('DuplicateMethodCall')).to eq(Reek::SmellDetectors::DuplicateMethodCall)
    end

    it 'raise NameError for an invalid detector name' do
      expect { described_class.to_detector('Unknown') }.to raise_error(NameError)
    end
  end

  describe '.configuration_keys' do
    it 'returns the right keys' do
      expected_keys = Reek::SmellDetectors::DuplicateMethodCall.configuration_keys.to_a
      expect(expected_keys).to eq([:enabled, :exclude, :max_calls, :allow_calls])
    end
  end
end

Version data entries

3 entries across 3 versions & 1 rubygems

Version	Path
reek-6.0.3	spec/reek/smell_detectors/base_detector_spec.rb
reek-6.0.2	spec/reek/smell_detectors/base_detector_spec.rb
reek-6.0.1	spec/reek/smell_detectors/base_detector_spec.rb