Sha256: b0683943b96171a7daefac0e76cc644f44b38c7f2d5d9959254ec84fe0ed72ba
Contents?: true
Size: 1.67 KB
Versions: 7
Compression:
Stored size: 1.67 KB
Contents
# frozen_string_literal: true
require 'spec_helper'
module RailsBestPractices
module Reviews
describe MoveCodeIntoHelperReview do
let(:runner) { Core::Runner.new(reviews: described_class.new('array_count' => 2)) }
it 'moves code into helper' do
content = <<-EOF
<%= select_tag :state, options_for_select( [[t(:draft), "draft"],
[t(:published), "published"]],
params[:default_state] ) %>
EOF
runner.review('app/views/posts/show.html.erb', content)
expect(runner.errors.size).to eq(1)
expect(runner.errors[0].to_s).to eq(
'app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)'
)
end
it 'does not move code into helper with simple arguments' do
content = <<-EOF
<%= select_tag :state, options_for_select( Post.STATES ) %>
EOF
runner.review('app/views/posts/show.html.erb', content)
expect(runner.errors.size).to eq(0)
end
it 'does not check ignored files' do
runner =
Core::Runner.new(
reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => %r{app/views/post})
)
content = <<-EOF
<%= select_tag :state, options_for_select( [[t(:draft), "draft"],
[t(:published), "published"]],
params[:default_state] ) %>
EOF
runner.review('app/views/posts/show.html.erb', content)
expect(runner.errors.size).to eq(0)
end
end
end
end
Version data entries
7 entries across 7 versions & 1 rubygems