Sha256: b00b74ec3f17f39c55b6a0d923e5ad80cef33a71c510b048e484cc7b03342d21
Contents?: true
Size: 726 Bytes
Versions: 10
Compression:
Stored size: 726 Bytes
Contents
require 'roodi/checks/check'
module Roodi
module Checks
# Checks if a method uses an argument to decide on what execution path to take
#
# It is a kind of duplication, since the caller knows what path should be taken.
# Also, it means the method has more than one responsibility.
class ControlCouplingCheck < Check
def interesting_nodes
[:defn, :lvar]
end
def evaluate_start_defn(node)
@method_name = node[1]
@arguments = node[2][1..-1]
end
def evaluate_start_lvar(node)
add_error "Method \"#{@method_name}\" uses the argument \"#{node[1]}\" for internal control." if @arguments.detect {|each| each == node[1]}
end
end
end
end
Version data entries
10 entries across 10 versions & 1 rubygems