# frozen_string_literal: true module RuboCop module Cop module Naming # This cop checks for memoized methods whose instance variable name # does not match the method name. # # This cop can be configured with the EnforcedStyleForLeadingUnderscores # directive. It can be configured to allow for memoized instance variables # prefixed with an underscore. Prefixing ivars with an underscore is a # convention that is used to implicitly indicate that an ivar should not # be set or referencd outside of the memoization method. # # @example EnforcedStyleForLeadingUnderscores: disallowed (default) # # bad # # Method foo is memoized using an instance variable that is # # not `@foo`. This can cause confusion and bugs. # def foo # @something ||= calculate_expensive_thing # end # # # good # def _foo # @foo ||= calculate_expensive_thing # end # # # good # def foo # @foo ||= calculate_expensive_thing # end # # # good # def foo # @foo ||= begin # calculate_expensive_thing # end # end # # # good # def foo # helper_variable = something_we_need_to_calculate_foo # @foo ||= calculate_expensive_thing(helper_variable) # end # # @example EnforcedStyleForLeadingUnderscores: required # # bad # def foo # @something ||= calculate_expensive_thing # end # # # bad # def foo # @foo ||= calculate_expensive_thing # end # # # good # def foo # @_foo ||= calculate_expensive_thing # end # # # good # def _foo # @_foo ||= calculate_expensive_thing # end # # @example EnforcedStyleForLeadingUnderscores :optional # # bad # def foo # @something ||= calculate_expensive_thing # end # # # good # def foo # @foo ||= calculate_expensive_thing # end # # # good # def foo # @_foo ||= calculate_expensive_thing # end # # # good # def _foo # @_foo ||= calculate_expensive_thing # end class MemoizedInstanceVariableName < Cop include ConfigurableEnforcedStyle MSG = 'Memoized variable `%s` does not match ' \ 'method name `%s`. Use `@%s` instead.'.freeze UNDERSCORE_REQUIRED = 'Memoized variable `%s` does not start ' \ 'with `_`. Use `@%s` instead.'.freeze def self.node_pattern memo_assign = '(or_asgn $(ivasgn _) _)' memoized_at_end_of_method = "(begin ... #{memo_assign})" instance_method = "(def $_ _ {#{memo_assign} #{memoized_at_end_of_method}})" class_method = "(defs self $_ _ {#{memo_assign} #{memoized_at_end_of_method}})" "{#{instance_method} #{class_method}}" end private_class_method :node_pattern def_node_matcher :memoized?, node_pattern def on_def(node) (method_name, ivar_assign) = memoized?(node) return if matches?(method_name, ivar_assign) msg = format( message(ivar_assign.children.first.to_s), var: ivar_assign.children.first.to_s, suggested_var: suggested_var(method_name), method: method_name ) add_offense(node, location: ivar_assign.source_range, message: msg) end alias on_defs on_def private def style_parameter_name 'EnforcedStyleForLeadingUnderscores' end def matches?(method_name, ivar_assign) return true if ivar_assign.nil? || method_name == :initialize method_name = method_name.to_s.delete('!?') variable = ivar_assign.children.first variable_name = variable.to_s.sub('@', '') return false unless valid_leading_underscore?(variable_name) variable_name.sub(/\A_/, '') == method_name.sub(/\A_/, '') end def message(variable) variable_name = variable.to_s.sub('@', '') return UNDERSCORE_REQUIRED if style == :required && !variable_name.start_with?('_') MSG end def suggested_var(method_name) suggestion = method_name.to_s.delete('!?') style == :required ? "_#{suggestion}" : suggestion end def valid_leading_underscore?(variable_name) case style when :required variable_name.start_with?('_') when :disallowed !variable_name.start_with?('_') else true end end end end end end