Sha256: ad913ddf1aae2ce5b3b0777545f73d383c154277139d58605bf1f1949fba1e67

Contents?: true

Size: 1.93 KB

Versions: 22

Compression:

Stored size: 1.93 KB

Contents

#
# Copyright:: 2019, Chef Software, Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefModernize
        # For many users the apt::default cookbook is used only to update apt's package cache. Chef Infra Client 12.7 and later include an apt_update resource which should be used to perform this instead. Keep in mind that some users will want to stick with the apt::default recipe as it also installs packages necessary for using https repositories on Debian systems and manages some configuration files.
        #
        # @example
        #
        #   # bad
        #   include_recipe 'apt::default'
        #   include_recipe 'apt'
        #
        #   # good
        #   apt_update
        #
        class IncludingAptDefaultRecipe < Cop
          extend TargetChefVersion

          minimum_target_chef_version '12.7'

          MSG = 'Do not include the Apt default recipe to update package cache. Instead use the apt_update resource, which is built into Chef Infra Client 12.7 and later.'.freeze

          def_node_matcher :apt_recipe_usage?, <<-PATTERN
            (send nil? :include_recipe (str {"apt" "apt::default"}))
          PATTERN

          def on_send(node)
            apt_recipe_usage?(node) do
              add_offense(node, location: :expression, message: MSG, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

22 entries across 22 versions & 1 rubygems

Version Path
cookstyle-6.11.4 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.10.2 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.9.0 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.8.0 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.7.3 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.6.9 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.5.3 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.4.4 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.23.0 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.3.4 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.2.9 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.2.5 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.1.6 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-6.0.19 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.22.6 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.21.9 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.20.0 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.19.9 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.18.4 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.17.4 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb