Sha256: a5203bce5a5fa00bd057f04f90b2bc447f28ec3fb019b5542ba530e16ce0b9fe

Contents?: true

Size: 1.43 KB

Versions: 6

Compression:

Stored size: 1.43 KB

Contents

# encoding: utf-8
# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks whether some constant value isn't a
      # mutable literal (e.g. array or hash).
      #
      # @example
      #   # bad
      #   CONST = [1, 2, 3]
      #
      #   # good
      #   CONST = [1, 2, 3].freeze
      class MutableConstant < Cop
        MSG = 'Freeze mutable objects assigned to constants.'.freeze

        include FrozenStringLiteral

        def on_casgn(node)
          _scope, _const_name, value = *node
          on_assignment(value)
        end

        def on_or_asgn(node)
          lhs, value = *node
          on_assignment(value) if lhs && lhs.type == :casgn
        end

        def autocorrect(node)
          expr = node.source_range
          lambda do |corrector|
            if node.array_type? && node.loc.begin.nil? && node.loc.end.nil?
              corrector.insert_before(expr, '[')
              corrector.insert_after(expr, '].freeze')
            else
              corrector.insert_after(expr, '.freeze')
            end
          end
        end

        private

        def on_assignment(value)
          return unless value
          return unless value.mutable_literal?
          return if FROZEN_STRING_LITERAL_TYPES.include?(value.type) &&
                    frozen_string_literals_enabled?(processed_source)

          add_offense(value, :expression)
        end
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 2 rubygems

Version Path
fluent-plugin-detect-memb-exceptions-0.0.2 vendor/bundle/ruby/2.0.0/gems/rubocop-0.42.0/lib/rubocop/cop/style/mutable_constant.rb
fluent-plugin-detect-memb-exceptions-0.0.1 vendor/bundle/ruby/2.0.0/gems/rubocop-0.42.0/lib/rubocop/cop/style/mutable_constant.rb
rubocop-0.42.0 lib/rubocop/cop/style/mutable_constant.rb
rubocop-0.41.2 lib/rubocop/cop/style/mutable_constant.rb
rubocop-0.41.1 lib/rubocop/cop/style/mutable_constant.rb
rubocop-0.41.0 lib/rubocop/cop/style/mutable_constant.rb