Sha256: 9e349a7040c41ef22efa6a6bea917c92a91bde654aca16649b1fe72cc0638d7c
Contents?: true
Size: 1.42 KB
Versions: 13
Compression:
Stored size: 1.42 KB
Contents
# Duplicate Method Call
## Introduction
Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.
Reek implements a check for _Duplicate Method Call_.
## Example
Here's a very much simplified and contrived example. The following method will report a warning:
```Ruby
def double_thing
@other.thing + @other.thing
end
```
One quick approach to silence Reek would be to refactor the code thus:
```Ruby
def double_thing
thing = @other.thing
thing + thing
end
```
A slightly different approach would be to replace all calls in `double_thing` by calls to `thing`:
```Ruby
class Other
def double_thing
thing + thing
end
def thing
@other.thing
end
end
```
The approach you take will depend on balancing other factors in your code.
## Current support in Reek
Reek's Duplicate Method Call detector checks for repeated identical method calls within any one method definition. This is intended to complement the checks performed by tools such as [Flay](http://ruby.sadi.st/Flay.html) and [Simian](http://www.redhillconsulting.com.au/products/simian/).
## Configuration
Reek's Duplicate Method Call detector currently offers the [Basic Smell Options](Basic-Smell-Options.md), plus:
Option | Value | Effect
-------|-------|-------
`max_calls` | integer | The maximum number of duplicate calls allowed within a method. Defaults to 1.
Version data entries
13 entries across 13 versions & 1 rubygems