Sha256: 9c09c0aaca4c52b05d9f9172a5d35f0e7fb23f92544a7e07ffe70ca1acc72002
Contents?: true
Size: 1.59 KB
Versions: 43
Compression:
Stored size: 1.59 KB
Contents
/**
* Rule: no-return-wrap function
* Prevents uneccessary wrapping of results in Promise.resolve
* or Promise.reject as the Promise will do that for us
*/
'use strict'
const getDocsUrl = require('./lib/get-docs-url')
const isPromise = require('./lib/is-promise')
function isInPromise(context) {
const expression = context
.getAncestors()
.filter(node => node.type === 'ExpressionStatement')[0]
return expression && expression.expression && isPromise(expression.expression)
}
module.exports = {
meta: {
docs: {
url: getDocsUrl('no-return-wrap')
},
messages: {
resolve: 'Avoid wrapping return values in Promise.resolve',
reject: 'Expected throw instead of Promise.reject'
}
},
create(context) {
const options = context.options[0] || {}
const allowReject = options.allowReject
return {
ReturnStatement(node) {
if (isInPromise(context)) {
if (node.argument) {
if (node.argument.type === 'CallExpression') {
if (node.argument.callee.type === 'MemberExpression') {
if (node.argument.callee.object.name === 'Promise') {
if (node.argument.callee.property.name === 'resolve') {
context.report({ node, messageId: 'resolve' })
} else if (
!allowReject &&
node.argument.callee.property.name === 'reject'
) {
context.report({ node, messageId: 'reject' })
}
}
}
}
}
}
}
}
}
}
Version data entries
43 entries across 43 versions & 1 rubygems